Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup script for logs and events #38

Merged
merged 6 commits into from
Jun 5, 2019
Merged

Conversation

samjsong
Copy link
Contributor

@samjsong samjsong commented Jun 4, 2019

  1. We update the setup script to include a source for logs and events, and attach -metrics suffix to metrics sources
  2. We rename the secret to sumologic and include all endpoints in this single secret
  3. We include an optional cluster field to the collector upon creation to keep it consistent with metrics

FYI - @ggarg2906sumo @yuting-liu @lei-sumo

Copy link
Contributor

@maimaisie maimaisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm. When I search for metric-endpoints in the repo there are some references in the README. do we plan to update that in a separate PR?

@samjsong
Copy link
Contributor Author

samjsong commented Jun 4, 2019

Thanks for the catch, let me make the relevant README changes in this PR

deploy/README.md Outdated
```

__NOTE__ This script will be executed in bash and requires [jq command-line JSON parser](https://stedolan.github.io/jq/download/) to be installed.

#### Parameters

* __-c collector-name__ - optional. Name of Sumo collector that will be created. If not specified, it will be named as `kubernetes-<timestamp>`
* __-k cluster-name__ - optional. Name of the Kubernetes cluster that will be attached to logs as metadata. If not specified, it will be named as `kubernetes-<timestamp>`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this change only apply to log? (how about metrics/event?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster name attaches the fields:{cluster:CLUSTER_NAME} to the metadata of the collector, which gets attached to all the logs sent to that collector. Actually since we receive events as logs in Sumo, this should also apply for events. For metrics, you have to set the same CLUSTER_NAME in the prometheus operator overrides.yaml

prometheus:
  prometheusSpec:
    externalLabels:
      # Set this to a value to distinguish between different k8s clusters
      cluster: kubernetes

Eventually this value can be enforced the same in the helm chart when we release that.

@samjsong samjsong merged commit b086a76 into master Jun 5, 2019
@samjsong samjsong deleted the ssong-fluentbit-script branch June 5, 2019 18:36
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
* add ad syncing tool

* remove test files

* go fmt

* update env options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants